From 072d43b7c340cd8ea0bcffb5484cbc1c7cf5b0f3 Mon Sep 17 00:00:00 2001
From: Eeshan Garg <jerryguitarist@gmail.com>
Date: Mon, 8 Jan 2018 21:05:48 -0330
Subject: [PATCH] tools/release_packages: Stop generating sdists.
Now that we do not use MANIFEST.in for zulip_bots, it doesn't
make sense to distribute sdists, because sdists don't pick up
data files specified in the package_data argument to setup().
Also, it isn't a huge deal if we don't distribute sdists for our
packages. Most PyPI projects only release wheels and pip will also
use wheels if available. So, this made sense!
---
tools/release-packages | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/tools/release-packages b/tools/release-packages
index e1afac78..ec52d125 100755
--- a/tools/release-packages
+++ b/tools/release-packages
@@ -41,9 +41,6 @@ def _generate_dist(dist_type, setup_file, package_name, setup_args):
)
print(crayons.green(message, bold=True))
-def generate_sdist(setup_file, package_name):
- _generate_dist('sdist', setup_file, package_name, ['sdist'])
-
def generate_bdist_wheel_universal(setup_file, package_name):
_generate_dist('bdist_wheel', setup_file, package_name,
['bdist_wheel', '--universal'])
@@ -69,12 +66,6 @@ def cleanup(package_dir):
print(crayons.green('Removing {}/*'.format(directory), bold=True))
shutil.rmtree(directory)
- if package_dir.endswith("zulip_bots"):
- manifest_file = os.path.join(package_dir, 'MANIFEST.in')
- if os.path.isfile(manifest_file):
- print(crayons.green('Removing {}'.format(manifest_file), bold=True))
- os.remove(manifest_file)
-
_rm_if_it_exists(build_dir)
_rm_if_it_exists(temp_dir)
_rm_if_it_exists(dist_dir)
@@ -235,7 +226,6 @@ def main():
for setup_file in setup_py_files:
package_name = os.path.basename(os.path.dirname(setup_file))
- generate_sdist(setup_file, package_name)
generate_bdist_wheel_universal(setup_file, package_name)
set_variable(bots_setup, 'IS_PYPA_PACKAGE', False)