janek/mostr-zulip-bot
1
0
Fork 0
Code Issues Pull requests Releases Activity

google_search: Add missing type annotations.

Browse source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2023-10-27 17:40:51 -07:00
parent 602ebb18fe
commit 5c299c7eff
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
zulip_bots/zulip_bots/bots/google_search/google_search.py
View file

@ -3,7 +3,7 @@ import logging
from typing import Dict, List from typing import Dict, List
import requests import requests
from bs4 import BeautifulSoup from bs4 import BeautifulSoup, Tag
from zulip_bots.lib import BotHandler from zulip_bots.lib import BotHandler
@ -16,7 +16,9 @@ def google_search(keywords: str) -> List[Dict[str, str]]:
soup = BeautifulSoup(page.text, "lxml") soup = BeautifulSoup(page.text, "lxml")
# Gets all search URLs # Gets all search URLs
anchors = soup.find(id="search").findAll("a") search = soup.find(id="search")
assert isinstance(search, Tag)
anchors = search.findAll("a")
results = [] results = []
for a in anchors: for a in anchors:

4
zulip_bots/zulip_bots/bots/google_search/test_google_search.py
View file

@ -32,9 +32,7 @@ class TestGoogleSearchBot(BotTestCase, DefaultTests):
def test_attribute_error(self) -> None: def test_attribute_error(self) -> None:
with self.mock_http_conversation("test_attribute_error"), patch("logging.exception"): with self.mock_http_conversation("test_attribute_error"), patch("logging.exception"):
self.verify_reply( self.verify_reply("test", "Error: Search failed. .")
"test", "Error: Search failed. 'NoneType' object has no attribute 'findAll'."
)
# Makes sure cached results, irrelevant links, or empty results are not displayed # Makes sure cached results, irrelevant links, or empty results are not displayed
def test_ignore_links(self) -> None: def test_ignore_links(self) -> None: