mypy: Enable no_implicit_reexport.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

pyproject.toml

@@ -32,7 +32,6 @@ disallow_subclassing_any = false
 disallow_untyped_calls = false
 disallow_untyped_decorators = false
 warn_return_any = false
-no_implicit_reexport = false
 
 # Enable optional errors.
 enable_error_code = [

zulip_bots/zulip_bots/bots/beeminder/test_beeminder.py

@@ -2,7 +2,8 @@ from unittest.mock import patch
 
 from requests.exceptions import ConnectionError
 
-from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler, get_bot_message_handler
+from zulip_bots.test_file_utils import get_bot_message_handler
+from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler
 
 
 class TestBeeminderBot(BotTestCase, DefaultTests):

zulip_bots/zulip_bots/bots/connect_four/test_connect_four.py

@@ -1,6 +1,6 @@
 from typing import Dict, List
 
-from zulip_bots.bots.connect_four.connect_four import ConnectFourModel
+from zulip_bots.bots.connect_four.controller import ConnectFourModel
 from zulip_bots.game_handler import BadMoveException
 from zulip_bots.test_lib import BotTestCase, DefaultTests
 

zulip_bots/zulip_bots/bots/dialogflow/test_dialogflow.py

@@ -3,7 +3,8 @@ from contextlib import contextmanager
 from typing import ByteString, Iterator
 from unittest.mock import patch
 
-from zulip_bots.test_lib import BotTestCase, DefaultTests, read_bot_fixture_data
+from zulip_bots.test_file_utils import read_bot_fixture_data
+from zulip_bots.test_lib import BotTestCase, DefaultTests
 
 
 class MockHttplibRequest:

zulip_bots/zulip_bots/bots/giphy/test_giphy.py

@@ -2,7 +2,8 @@ from unittest.mock import patch
 
 from requests.exceptions import ConnectionError
 
-from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler, get_bot_message_handler
+from zulip_bots.test_file_utils import get_bot_message_handler
+from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler
 
 
 class TestGiphyBot(BotTestCase, DefaultTests):

zulip_bots/zulip_bots/bots/github_detail/test_github_detail.py

@@ -1,4 +1,5 @@
-from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler, get_bot_message_handler
+from zulip_bots.test_file_utils import get_bot_message_handler
+from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler
 
 
 class TestGithubDetailBot(BotTestCase, DefaultTests):

zulip_bots/zulip_bots/bots/incrementor/test_incrementor.py

@@ -1,6 +1,7 @@
 from unittest.mock import patch
 
-from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler, get_bot_message_handler
+from zulip_bots.test_file_utils import get_bot_message_handler
+from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler
 
 
 class TestIncrementorBot(BotTestCase, DefaultTests):

zulip_bots/zulip_bots/bots/salesforce/test_salesforce.py

@@ -4,7 +4,8 @@ from unittest.mock import patch
 
 from simple_salesforce.exceptions import SalesforceAuthenticationFailed
 
-from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler, read_bot_fixture_data
+from zulip_bots.test_file_utils import read_bot_fixture_data
+from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler
 
 
 @contextmanager

zulip_bots/zulip_bots/bots/trivia_quiz/test_trivia_quiz.py

@@ -11,7 +11,8 @@ from zulip_bots.bots.trivia_quiz.trivia_quiz import (
     update_quiz,
 )
 from zulip_bots.request_test_lib import mock_request_exception
-from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler, read_bot_fixture_data
+from zulip_bots.test_file_utils import read_bot_fixture_data
+from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler
 
 
 class TestTriviaQuizBot(BotTestCase, DefaultTests):

zulip_bots/zulip_bots/bots/twitpost/test_twitpost.py

@@ -1,7 +1,7 @@
 from unittest.mock import patch
 
-from zulip_bots.test_file_utils import read_bot_fixture_data
-from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler, get_bot_message_handler
+from zulip_bots.test_file_utils import get_bot_message_handler, read_bot_fixture_data
+from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler
 
 
 class TestTwitpostBot(BotTestCase, DefaultTests):

zulip_bots/zulip_bots/bots/witai/test_witai.py

@@ -1,7 +1,8 @@
 from typing import Any, Dict, Optional
 from unittest.mock import patch
 
-from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler, get_bot_message_handler
+from zulip_bots.test_file_utils import get_bot_message_handler
+from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler
 
 
 class TestWitaiBot(BotTestCase, DefaultTests):

zulip_bots/zulip_bots/bots/youtube/test_youtube.py

@@ -3,7 +3,8 @@ from unittest.mock import patch
 
 from requests.exceptions import ConnectionError, HTTPError
 
-from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler, get_bot_message_handler
+from zulip_bots.test_file_utils import get_bot_message_handler
+from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler
 
 
 class TestYoutubeBot(BotTestCase, DefaultTests):

zulip_bots/zulip_bots/tests/test_run.py

@@ -7,8 +7,9 @@ from typing import Optional
 from unittest import TestCase, mock
 from unittest.mock import MagicMock, patch
 
+import importlib_metadata as metadata
+
 import zulip_bots.run
-from zulip_bots.finder import metadata
 from zulip_bots.lib import extract_query_without_mention
 
 

zulip_botserver/tests/test_server.py

@@ -8,7 +8,8 @@ from types import ModuleType
 from typing import Any, Dict
 from unittest import mock
 
-from zulip_bots.finder import metadata
+import importlib_metadata as metadata
+
 from zulip_bots.lib import BotHandler
 from zulip_botserver import server
 from zulip_botserver.input_parameters import parse_args