Commit graph

2418 commits

Author SHA1 Message Date
Anders Kaseorg
5c934e544d ruff: Fix PLR1722 Use sys.exit() instead of exit.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-30 11:44:10 -07:00
Anders Kaseorg
93bb7eb61e ruff: Fix PLR1714 Consider merging multiple comparisons.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-30 11:44:10 -07:00
Anders Kaseorg
192024ebc7 ruff: Fix PLR1711 Useless return statement at end of function.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-30 11:44:10 -07:00
Anders Kaseorg
54263e5d52 ruff: Fix N818 Exception name should be named with an Error suffix.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-30 11:44:10 -07:00
Anders Kaseorg
a8aec780d2 ruff: Fix N816 Variable in global scope should not be mixedCase.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-30 11:44:10 -07:00
Anders Kaseorg
87e7d31403 ruff: Fix N806 Variable in function should be lowercase.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-30 11:44:10 -07:00
Anders Kaseorg
5e708e3661 ruff: Fix N803 Argument name should be lowercase.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-30 11:44:10 -07:00
Anders Kaseorg
d5ad3300c7 ruff: Fix N802 Function name should be lowercase.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-30 11:44:10 -07:00
Anders Kaseorg
2c4e7069ad ruff: Fix N801 Class name should use CapWords convention.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-30 11:44:10 -07:00
Anders Kaseorg
272c63bfd3 ruff: Fix B009 Do not call getattr with a constant attribute value.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
7aeb8f2619 ruff: Fix PIE810 Call startswith once with a tuple.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
ad9c085614 ruff: Fix PIE808 Unnecessary start argument in range.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
008efed12b ruff: Fix SIM300 Yoda conditions are discouraged.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
8b5b3958e1 ruff: Fix SIM201 Use … != … instead of not … == ….
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
93156d994a ruff: Fix SIM118 Use key in dict instead of key in dict.keys().
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
6a37290cec ruff: Fix SIM114 Combine if branches using logical or operator.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
b009dcd7d3 ruff: Fix SIM108 Use ternary operator instead of if-else-block.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
2aa36f90fb ruff: Fix SIM105 Use contextlib.suppress instead of try-except-pass.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
6a4ad8861b ruff: Fix SIM103 Return the condition directly.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
58a3026f37 ruff: Fix SIM102 Use a single if statement instead of nested if statements.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
c75f5b3a09 ruff: Fix SIM101 Multiple isinstance calls for val, merge into a single call.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 18:17:39 -07:00
Anders Kaseorg
13e860ee10 ruff: Fix C417 Unnecessary map usage (rewrite using a generator expression).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 17:36:51 -07:00
Anders Kaseorg
774edb434e ruff: Fix C400 Unnecessary generator (rewrite as a list comprehension).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 17:36:51 -07:00
Anders Kaseorg
353c2de050 ruff: Fix EXE002 The file is executable but no shebang is present.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 16:54:40 -07:00
Anders Kaseorg
ca3e5a2746 ruff: Fix EXE001 Shebang is present but file is not executable.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-29 16:54:40 -07:00
Anders Kaseorg
235f92afb0 ruff: Fix TRY401 Redundant exception object included in logging.exception call.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-28 16:29:20 -07:00
Anders Kaseorg
6b2861c3ec ruff: Fix G004 Logging statement uses f-string.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-28 16:18:11 -07:00
Anders Kaseorg
d85ace8e7e ruff: Fix G003 Logging statement uses +.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-28 16:17:21 -07:00
Anders Kaseorg
02e0555e0d ruff: Fix G002 Logging statement uses %.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-28 16:17:21 -07:00
Anders Kaseorg
e537bbefdf ruff: Fix G001 Logging statement uses str.format.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-28 16:17:21 -07:00
Anders Kaseorg
1ccb5db6ef ruff: Fix G010 Logging statement uses warn instead of warning.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-28 16:17:21 -07:00
Anders Kaseorg
88ab78ee25 ruff: Fix RSE102 Unnecessary parentheses on raised exception.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-28 16:17:21 -07:00
Anders Kaseorg
63246e4369 ruff: Fix RUF010 Use explicit conversion flag.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 22:41:04 -07:00
Anders Kaseorg
52a7b0b6a3 ruff: Fix ISC003 Explicitly concatenated string should be implicitly concatenated.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 22:14:10 -07:00
Anders Kaseorg
c471f26d45 ruff: Fix ISC001 Implicitly concatenated string literals on one line.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 22:14:10 -07:00
Anders Kaseorg
2f581293d9 ruff: Fix FLY002 Consider f-string instead of string join.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 22:09:17 -07:00
Anders Kaseorg
fcd4fe330d ruff: Fix UP031 Use format specifiers instead of percent format.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 22:04:41 -07:00
Anders Kaseorg
ddccf0eda3 ruff: Fix UP032 Use f-string instead of format call.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 22:01:58 -07:00
Anders Kaseorg
a49add3d02 lint: Replace Black with Ruff.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 19:08:40 -07:00
Anders Kaseorg
2a0eff653d lint: Replace isort with Ruff.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 19:04:29 -07:00
Anders Kaseorg
01a27a3a1b lint: Replace Flake8 with Ruff.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 18:58:49 -07:00
Anders Kaseorg
61abe11c1a run-mypy: Remove options that duplicate the mypy configuration.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 17:53:37 -07:00
Anders Kaseorg
5c0f88d1e1 mypy: Improve configuration.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 17:53:37 -07:00
Anders Kaseorg
b725058e0a requirements: Add typing stubs for beautifulsoup4 and httplib2.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 17:47:53 -07:00
Anders Kaseorg
5c299c7eff google_search: Add missing type annotations.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 17:47:53 -07:00
Anders Kaseorg
602ebb18fe connect_four: Add missing type annotations.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 17:40:41 -07:00
Anders Kaseorg
a2cbd7ef68 requirements: Install zulint non-editable so mypy can find it.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-27 17:14:25 -07:00
Anders Kaseorg
4b7bfb644f requirements: Upgrade zulint.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-26 17:36:00 -07:00
Anders Kaseorg
6cb1d5f775 mypy: Enable explicit-override error.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-26 14:03:17 -07:00
Anders Kaseorg
43654b9cf2 mypy: Enable ignore-without-code error.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-26 13:43:42 -07:00