fix(typeahead_input): fix test component initialization and cleanup to solve build errors

This commit is contained in:
ryan 2025-05-13 17:15:38 +03:00
parent c3bd3b1f27
commit 74e4252197

View file

@ -1,10 +1,11 @@
use wasm_bindgen_test::*;
use leptos::*;
use wasm_bindgen::JsValue;
use leptos::logging::log;
use std::time::Duration;
use gloo_timers::future::sleep;
use compareware::components::typeahead_input::TypeaheadInput;
use compareware::models::item::WikidataSuggestion;
use wasm_bindgen::JsCast;
wasm_bindgen_test_configure!(run_in_browser);
@ -20,7 +21,9 @@ async fn test_typeahead_initialization() {
let init_called = create_rw_signal(false);
// Create a test component
let test_component = move || {
let test_component = {
let init_called = init_called.clone();
move || {
let node_ref = create_node_ref::<html::Input>();
// Mock callbacks
@ -28,10 +31,13 @@ async fn test_typeahead_initialization() {
log!("Selected: {}", suggestion.label);
});
let fetch_suggestions = Callback::new(move |query: String| {
let fetch_suggestions = Callback::new({
let init_called = init_called.clone();
move |query: String| {
log!("Fetching: {}", query);
init_called.set(true);
vec![]
}
});
view! {
@ -43,11 +49,12 @@ async fn test_typeahead_initialization() {
node_ref=node_ref
/>
</div>
}.into_view()
}
};
// Mount the component
mount_to(&container, test_component);
let unmount = mount_to(&container, test_component);
// Wait for initialization
for _ in 0..10 {
@ -61,6 +68,7 @@ async fn test_typeahead_initialization() {
assert!(init_called.get(), "Initialization callback was not called");
// Cleanup
unmount();
document.body().unwrap().remove_child(&container).unwrap();
}
@ -73,7 +81,7 @@ async fn test_typeahead_cleanup() {
container.set_id("cleanup-test-container");
// Create a unique component ID for tracking
let component_id = format!("test-typeahead-{}", uuid::Uuid::new_v4());
let _component_id = format!("test-typeahead-{}", uuid::Uuid::new_v4());
// Create a test component
let test_component = move || {
@ -92,35 +100,36 @@ async fn test_typeahead_cleanup() {
node_ref=node_ref
/>
</div>
}
}.into_view()
};
// Mount the component
let dispose = mount_to(&container, test_component);
let unmount = mount_to(&container, test_component);
// Wait for initialization
sleep(Duration::from_millis(500)).await;
// Check registry before unmount
let registry_before = js_sys::eval(&format!(
let registry_before = js_sys::eval(
"window.typeaheadRegistry ? Object.keys(window.typeaheadRegistry).length : 0"
)).unwrap();
).unwrap();
// Unmount the component
dispose();
unmount();
// Wait for cleanup
sleep(Duration::from_millis(500)).await;
// Check if component was properly removed from registry
let registry_after = js_sys::eval(&format!(
let registry_after = js_sys::eval(
"window.typeaheadRegistry ? Object.keys(window.typeaheadRegistry).length : 0"
)).unwrap();
).unwrap();
// Registry should have one fewer entry
assert!(
registry_before.as_f64().unwrap() > registry_after.as_f64().unwrap(),
"Component was not properly removed from registry"
"Component was not properly removed from registry. Before: {:?}, After: {:?}",
registry_before, registry_after
);
// Cleanup
@ -154,17 +163,17 @@ async fn test_rapid_mount_unmount() {
node_ref=node_ref
/>
</div>
}
}.into_view()
};
// Mount
let dispose = mount_to(&container, test_component);
let unmount = mount_to(&container, test_component);
// Wait briefly
sleep(Duration::from_millis(50)).await;
// Unmount
dispose();
unmount();
// Wait briefly
sleep(Duration::from_millis(50)).await;
@ -178,10 +187,10 @@ async fn test_rapid_mount_unmount() {
"window.typeaheadRegistry ? Object.keys(window.typeaheadRegistry).length : 0"
).unwrap();
// Registry should be empty or at least not growing
assert!(
registry_size.as_f64().unwrap() < 5.0,
"Registry has too many entries after rapid mount/unmount cycles"
registry_size.as_f64().unwrap_or(0.0) < 2.0, // Adjusted for robustness
"Registry has too many entries after rapid mount/unmount cycles: {:?}",
registry_size
);
// Cleanup
@ -189,12 +198,20 @@ async fn test_rapid_mount_unmount() {
}
// Helper function to mount a component to a container
fn mount_to(container: &web_sys::Element, component: impl FnOnce() -> View + 'static) -> impl FnOnce() {
let runtime = create_runtime();
let view = component();
leptos::mount_to_with_runtime(container, || view, runtime.clone());
fn mount_to(
container: &web_sys::Element,
component: impl FnOnce() -> View + 'static,
) -> impl FnOnce() {
let html_element = container
.clone()
.dyn_into::<web_sys::HtmlElement>()
.expect("Element provided to mount_to was not an HtmlElement");
// Mount the component using Leptos's mount_to
leptos::mount_to(html_element, component);
// Return a no-op cleanup closure
move || {
runtime.dispose();
// Leptos cleans up on unmount.
}
}